fix(guide-ci): Slack notify must not fail the deploy #9

2026-07-08T14:20:32-04:00

hiveiq commented

2026-07-08 14:20:32 -04:00

Run #4 went red even though the guide deploy succeeded — my Notify Slack step let its own exit status fail the job. Fix: continue-on-error: true, curl exit never propagates (logs the HTTP code instead), and first-line via param-expansion.

Merging this auto-triggers a fresh cd-develop run (workflow path). That run should be GREEN, and the slack notify HTTP: log line will tell us if the runner reaches Slack (200) or not.

Run #4 went red even though the guide deploy succeeded — my Notify Slack step let its own exit status fail the job. Fix: `continue-on-error: true`, curl exit never propagates (logs the HTTP code instead), and first-line via param-expansion. **Merging this auto-triggers a fresh cd-develop run** (workflow path). That run should be GREEN, and the `slack notify HTTP:` log line will tell us if the runner reaches Slack (200) or not.

hiveiq added 2 commits 2026-07-08 14:20:33 -04:00

docs(guide): remove legacy SmartJournal reference 1037614364

Reword journal Overview to drop the 'legacy SmartJournal dependency' mention
and remove smartjournal from the coverage-reconcile deprecated skip-list.
qds-monitor stays in the skip-list (deprecated, intentionally undocumented).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(guide-ci): make Slack notify step non-fatal + reachability probe e1fcd4c00b

The Notify Slack step could fail the whole job (turning a successful deploy
red, as just happened). A notification must never fail a deploy:
- continue-on-error: true on the step
- curl captures HTTP code and never propagates a non-zero exit (|| echo)
- logs "slack notify HTTP: <code>" so we can see if the runner reaches Slack
- first commit line via ${VAR%%$'\n'*} param-expansion (no head pipe)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

johannes approved these changes 2026-07-08 14:22:11 -04:00

Dismissed

johannes approved these changes 2026-07-08 14:22:44 -04:00

hiveiq merged commit 1d88370c71 into develop

2026-07-08 14:23:06 -04:00

hiveiq deleted branch fix/slack-notify-nonfatal

2026-07-08 14:23:06 -04:00

hiveiq referenced this pull request

2026-07-08 17:00:37 -04:00

[CI] cd-develop run flipped to `failure` ~30 min AFTER the job succeeds (act_runner v0.2.11 / Gitea status-reconciliation) — NOT the smoke window #12

hiveiq referenced this pull request

2026-07-08 17:12:15 -04:00